chaoyli commented on a change in pull request #329: Change PaloMetrics' name and Catalog's Id generator URL: https://github.com/apache/incubator-doris/pull/329#discussion_r234935906
########## File path: fe/src/main/java/org/apache/doris/catalog/CatalogIdGenerator.java ########## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.catalog; + +import org.apache.doris.common.io.Writable; +import org.apache.doris.persist.EditLog; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.io.DataInput; +import java.io.DataOutput; +import java.io.IOException; + +// This new Id generator is just same as TransactionIdGenerator. +// But we can't just use TransactionIdGenerator to replace the old catalog's 'nextId' for compatibility reason. +// cause they are using different edit log operation type. +public class CatalogIdGenerator implements Writable { + private static final Logger LOG = LogManager.getLogger(CatalogIdGenerator.class); + + private static final int BATCH_ID_INTERVAL = 1000; + + private long nextId; + // has to set it to an invalid value, then it will be logged when id is firstly increment + private long batchEndId = -1; + + private EditLog editLog; + + public CatalogIdGenerator(long initValue) { + nextId = initValue; + } + + public void setEditLog(EditLog editLog) { + this.editLog = editLog; + } + + // performance is more quickly + public synchronized long getNextId() { + if (nextId < batchEndId) { Review comment: nextId is set to 10000. Some successive id is ignored by this function? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
