yiguolei commented on a change in pull request #334: Modify partition's version
name to what it means
URL: https://github.com/apache/incubator-doris/pull/334#discussion_r235317671
##########
File path:
fe/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java
##########
@@ -68,8 +68,8 @@ private void publishVersion() {
// attention here, we publish transaction state to all backends
including dead backend, if not publish to dead backend
// then transaction manager will treat it as success
List<Long> allBackends =
Catalog.getCurrentSystemInfo().getBackendIds(false);
- if (allBackends == null || allBackends.size() == 0) {
- LOG.warn("some transaction state need to publish, but no alive
backends!!!");
+ if (allBackends.isEmpty()) {
+ LOG.warn("some transaction state need to publish, but no backend
exists");
return;
Review comment:
if allbackends == null ,then nptr throws
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
