imay commented on a change in pull request #338: Fix compile issue of
thirdparty library
URL: https://github.com/apache/incubator-doris/pull/338#discussion_r235587748
##########
File path: thirdparty/build-thirdparty.sh
##########
@@ -57,17 +57,18 @@ ${TP_DIR}/download-thirdparty.sh
export LD_LIBRARY_PATH=$TP_DIR/installed/lib:$LD_LIBRARY_PATH
-if [ -f ${DORIS_TOOLCHAIN}/gcc730/bin/gcc ]; then
- GCC_HOME=${DORIS_TOOLCHAIN}/gcc730
- export CC=${GCC_HOME}/bin/gcc
- export CPP=${GCC_HOME}/bin/cpp
- export CXX=${GCC_HOME}/bin/g++
+# set COMPILER
+if [[ -z ${DORIS_GCC_HOME} ]]; then
Review comment:
you can remove this `if`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
