morningman commented on a change in pull request #333: Add distributor which
schedule task to be fairly
URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235835812
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -195,30 +195,8 @@ public RoutineLoadJob getJob(String jobId) {
List<RoutineLoadJob> jobs = new ArrayList<>();
Collection<RoutineLoadJob> stateJobs = null;
LOG.debug("begin to get routine load job by state {}",
jobState.name());
- switch (jobState) {
- case NEED_SCHEDULER:
- stateJobs = idToRoutineLoadJob.values().stream()
- .filter(entity -> entity.getState() ==
RoutineLoadJob.JobState.NEED_SCHEDULER)
- .collect(Collectors.toList());
- break;
- case PAUSED:
- stateJobs = idToRoutineLoadJob.values().stream()
- .filter(entity -> entity.getState() ==
RoutineLoadJob.JobState.PAUSED)
- .collect(Collectors.toList());
- break;
- case RUNNING:
- stateJobs = idToRoutineLoadJob.values().stream()
- .filter(entity -> entity.getState() ==
RoutineLoadJob.JobState.RUNNING)
- .collect(Collectors.toList());
- break;
- case STOPPED:
- stateJobs = idToRoutineLoadJob.values().stream()
- .filter(entity -> entity.getState() ==
RoutineLoadJob.JobState.STOPPED)
- .collect(Collectors.toList());
- break;
- default:
- break;
- }
+ idToRoutineLoadJob.values().stream()
Review comment:
You missed assigning 'stateJobs' variable....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
