kangkaisen commented on issue #344: Fix wrong query result when column value is Null URL: https://github.com/apache/incubator-doris/pull/344#issuecomment-441418220 > > @imay I think if there is filter for column c like c > 1 or c <=1, which will mean c could not be null. > > @kangkaisen Yes, c could not be null, however your change will add null to scan_keys @imay Hi, I think this patch won't add null to C column scan_keys. If c = 1 or c > 1, the code won't goto this branch ``` } else { if (range.is_fixed_value_convertible() && _is_convertible) { if (_begin_scan_keys.empty()) { if (range.get_convertible_fixed_value_size() < config::doris_max_scan_key_num) { range.convert_to_fixed_value(); has_converted = true; } } else { if (range.get_convertible_fixed_value_size() * _begin_scan_keys.size() < config::doris_max_scan_key_num) { range.convert_to_fixed_value(); has_converted = true; } } } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
