EmmyMiao87 commented on a change in pull request #368: Add a frontend interface
for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238951394
##########
File path:
fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
##########
@@ -766,6 +781,10 @@ private boolean checkTxnHasRelatedJob(TransactionState
txnState, Map<Long, Set<L
return true;
}
+ if (txnState.getSourceType() == LoadJobSourceType.ROUTINE_LOAD_TASK) {
+ return txnState.getCallBack().checkTxnHasRelatedJob(txnState);
Review comment:
Yes, it need. The reason is that task will be add into a needSchedulerQueue
when it is created. Before task scheduler to be, the txn state of task is
PREPARE. At the same time, GlobelTransactionMgr clean old transactions include
PREPARE. The task and txn of task live and die together
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
