uestctxq commented on a change in pull request #390: Fix building Docker image 
error
URL: https://github.com/apache/incubator-doris/pull/390#discussion_r238988621
 
 

 ##########
 File path: env.sh
 ##########
 @@ -31,23 +31,6 @@ if [[ -z ${DORIS_THIRDPARTY} ]]; then
     export DORIS_THIRDPARTY=${DORIS_HOME}/thirdparty
 fi
 
-# check java version
 
 Review comment:
   I have seen the build script, the check java also in build.sh.  Why you 
build jdk after check java in the build-thirdparty.sh? And I have test the 
build after I delete this. You can test it in your environment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to