imay commented on a change in pull request #390: Fix building Docker image error
URL: https://github.com/apache/incubator-doris/pull/390#discussion_r238991008
##########
File path: env.sh
##########
@@ -31,23 +31,6 @@ if [[ -z ${DORIS_THIRDPARTY} ]]; then
export DORIS_THIRDPARTY=${DORIS_HOME}/thirdparty
fi
-# check java version
Review comment:
JAVA_HOME can be set by user in his environment, and not everyone use
thirdparty's JDK as his JAVA_HOME.
So, we need to check java's version to make sure it can work with our
project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
