kangpinghuang commented on a change in pull request #399: Add Rowset Interface URL: https://github.com/apache/incubator-doris/pull/399#discussion_r239386489
########## File path: gensrc/proto/olap_file.proto ########## @@ -58,6 +58,39 @@ message PDelta { optional DeleteConditionMessage delete_condition = 6; } +enum RowsetType { + ALPHA_ROWSET = 0; // doris原有的列存格式 + BETA_ROWSET = 1; // 新列存 +} + +enum RowsetState { + PREPARING = 0; // 表示正在写入Rowset + COMMITTED = 1; // 表示rowset 写入完成,但是用户还不可见;这个状态下的rowset,BE不能自行判断是否删除,必须由FE的指令 + VISIBLE = 2; // 表示rowset 已经对用户可见 +} + +message RowsetMetaPb { + required int64 rowset_id = 1; + // RowsetMeta update version + required int64 version = 2; + optional int64 tablet_id = 3; + optional int32 tablet_schema_hash = 4; + optional RowsetType rowset_type = 5; + optional RowsetState rowset_state = 6; + // Rowset data version range + optional int32 start_version = 7; + optional int32 end_version = 8; + optional int32 row_number = 9; + optional int64 total_disk_size = 10; + optional int64 data_disk_size = 11; + optional int64 index_disk_size = 12; + // column min/max/null flag statistic info + repeated ColumnPruning column_statistics = 13; + optional DeleteConditionMessage delete_condition = 14; + // spare field id 15-49 for future use + optional bytes extra_properties = 50; Review comment: we do not want to modify the RowsetMetaPb message when add a new Rowset Type ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org