kangpinghuang commented on a change in pull request #368: Add a frontend
interface for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r239709047
##########
File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -137,93 +137,93 @@ public long getTransactionId() {
public Boolean isRepartition() {
return isRepartition;
}
-
+
public String getDb() {
return tblName.getDb();
}
-
+
// TODO(zc): used to get all dbs for lock
public void getDbs(Analyzer analyzer, Map<String, Database> dbs) throws
AnalysisException {
// get dbs of statement
queryStmt.getDbs(analyzer, dbs);
// get db of target table
tblName.analyze(analyzer);
String dbName = tblName.getDb();
-
+
// check exist
Database db = analyzer.getCatalog().getDb(dbName);
if (db == null) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_BAD_DB_ERROR,
dbName);
}
-
+
// check access
if
(!Catalog.getCurrentCatalog().getAuth().checkTblPriv(ConnectContext.get(),
tblName.getDb(), tblName.getTbl(),
PrivPredicate.LOAD)) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_TABLEACCESS_DENIED_ERROR,
"LOAD",
ConnectContext.get().getQualifiedUser(),
ConnectContext.get().getRemoteIP(), tblName.getTbl());
}
-
+
dbs.put(dbName, db);
}
-
+
public QueryStmt getQueryStmt() {
return queryStmt;
}
-
-
+
+
Review comment:
additional empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
