kangpinghuang commented on a change in pull request #437: Move tablet
management code from StorageEngine to TabletManager
URL: https://github.com/apache/incubator-doris/pull/437#discussion_r242035097
##########
File path: be/src/olap/store.cpp
##########
@@ -437,18 +437,19 @@ OLAPStatus OlapStore::deregister_tablet(Tablet* tablet) {
return OLAP_SUCCESS;
}
-std::string OlapStore::get_shard_path_from_header(const std::string&
shard_string) {
+std::string OlapStore::get_absolute_shard_path(const std::string&
shard_string) {
return _path + DATA_PREFIX + "/" + shard_string;
}
-std::string OlapStore::get_tablet_schema_hash_path_from_header(TabletMeta*
header) {
- return _path + DATA_PREFIX + "/" + std::to_string(header->shard())
+std::string OlapStore::get_tablet_path_from_header(TabletMeta* header, bool
with_schema_hash) {
Review comment:
I think the function name "get_tablet_path" is better， header will be
renamed to tablet meta. and "from_header" is additional, because we do not have
"get_tablet_path_from_other"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
