EmmyMiao87 commented on a change in pull request #456: Add routine load 
statement
URL: https://github.com/apache/incubator-doris/pull/456#discussion_r243789427
 
 

 ##########
 File path: 
fe/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java
 ##########
 @@ -149,6 +165,35 @@ protected RoutineLoadTaskInfo 
reNewTask(RoutineLoadTaskInfo routineLoadTaskInfo)
         return kafkaTaskInfo;
     }
 
+    public static KafkaRoutineLoadJob fromCreateStmt(CreateRoutineLoadStmt 
stmt) {
+        // find dbId
 
 Review comment:
   If lock of database should be get from outside of `Database`? Although it 
has public method 'readlock'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to