kangpinghuang commented on a change in pull request #505: Change reference to
pointer in task
URL: https://github.com/apache/incubator-doris/pull/505#discussion_r245618007
##########
File path: be/src/olap/task/engine_schema_change_task.cpp
##########
@@ -24,8 +24,8 @@ namespace doris {
using std::to_string;
EngineSchemaChangeTask::EngineSchemaChangeTask(const TAlterTabletReq&
alter_tablet_request,
- int64_t signature, const TTaskType::type task_type, vector<string>&
error_msgs,
- string& process_name):
+ int64_t signature, const TTaskType::type task_type, vector<string>*
error_msgs,
+ const string& process_name):
Review comment:
move input argments before output argments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
