kangpinghuang commented on a change in pull request #508: Compile cancel delete
task
URL: https://github.com/apache/incubator-doris/pull/508#discussion_r245863421
##########
File path: be/src/olap/task/engine_cancel_delete_task.cpp
##########
@@ -53,7 +53,8 @@ OLAPStatus EngineCancelDeleteTask::_cancel_delete() {
DeleteConditionHandler cond_handler;
for (TabletSharedPtr temp_tablet : table_list) {
temp_tablet->obtain_header_wrlock();
- res = cond_handler.delete_cond(temp_tablet, _request.version, false);
+ del_cond_array* delete_conditions =
temp_tablet->mutable_delete_predicate();
Review comment:
here is not mutablet_delete_predicate()， I think here should call
delete_predicates()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
