chaoyli commented on a change in pull request #510: Be refactor optimize rowset
URL: https://github.com/apache/incubator-doris/pull/510#discussion_r245957266
##########
File path: be/src/olap/rowset/alpha_rowset_meta.cpp
##########
@@ -22,8 +22,8 @@
namespace doris {
bool AlphaRowsetMeta::deserialize_extra_properties() {
- std::string extra_properties = get_extra_properties();
- bool parsed = _extra_meta_pb.ParseFromString(extra_properties);
+ std::string properties = extra_properties();
+ bool parsed = _extra_meta_pb.ParseFromString(properties);
Review comment:
May be better to like this?
```
return _extra_meta_pb.ParseFromString(properties);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
