kangpinghuang commented on a change in pull request #516: Modify compaction
code to be adapted to Rowset interface
URL: https://github.com/apache/incubator-doris/pull/516#discussion_r246647019
##########
File path: be/src/olap/reader.cpp
##########
@@ -308,13 +308,13 @@ OLAPStatus Reader::init(const ReaderParams& read_params)
{
return res;
}
- res = _acquire_data_sources(read_params);
+ res = _capture_rs_readers(read_params);
if (res != OLAP_SUCCESS) {
OLAP_LOG_WARNING("fail to init reader when acquire data
sources.[res=%d]", res);
return res;
}
- for (auto i_data: _data_sources) {
+ for (auto i_data : _rs_readers) {
Review comment:
change i_data to rs_reader?
auto -> auto&?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
