yiguolei commented on a change in pull request #564: Change CreateTablet
implemention
URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249649686
##########
File path: be/src/olap/base_compaction.cpp
##########
@@ -309,13 +309,13 @@ OLAPStatus
BaseCompaction::_do_base_compaction(VersionHash new_base_version_hash
// 1. 生成新base文件对应的olap index
RowsetId rowset_id = 0;
RowsetIdGenerator::instance()->get_next_id(_tablet->data_dir(),
&rowset_id);
- RowsetBuilderContext context = {_tablet->partition_id(),
_tablet->tablet_id(),
- _tablet->schema_hash(), rowset_id,
- RowsetTypePB::ALPHA_ROWSET,
_tablet->rowset_path_prefix(),
- _tablet->tablet_schema(),
_tablet->num_key_fields(),
- _tablet->num_short_key_fields(),
_tablet->num_rows_per_row_block(),
- _tablet->compress_kind(),
_tablet->bloom_filter_fpp()};
- RowsetBuilder* builder = new AlphaRowsetBuilder();
+ RowsetWriterContext context = {_tablet->partition_id(),
_tablet->tablet_id(),
+ _tablet->schema_hash(), rowset_id,
+ RowsetTypePB::ALPHA_ROWSET,
_tablet->rowset_path_prefix(),
+ _tablet->tablet_schema(),
_tablet->num_key_fields(),
+ _tablet->num_short_key_fields(),
_tablet->num_rows_per_row_block(),
+ _tablet->compress_kind(),
_tablet->bloom_filter_fpp()};
+ RowsetWriter* builder = new AlphaRowsetWriter();
Review comment:
Maybe should create a rowsetwriterfactory to create different rowsetwrite
according to the rowset type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
