chaoyli commented on a change in pull request #563: Modify schema change to use
rowset
URL: https://github.com/apache/incubator-doris/pull/563#discussion_r250470742
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -663,66 +675,18 @@ SchemaChangeDirectly::~SchemaChangeDirectly() {
SAFE_DELETE(_dst_cursor);
}
-bool SchemaChangeDirectly::_write_row_block(ColumnDataWriter* writer,
RowBlock* row_block) {
+bool SchemaChangeDirectly::_write_row_block(RowsetBuilderSharedPtr
rowset_builder, RowBlock* row_block) {
for (uint32_t i = 0; i < row_block->row_block_info().row_num; i++) {
- if (OLAP_SUCCESS != writer->attached_by(_dst_cursor)) {
- OLAP_LOG_WARNING("fail to attach writer");
+ if (OLAP_SUCCESS != rowset_builder->add_row(_dst_cursor)) {
Review comment:
where content of _dst_cursor comes from?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
