kangpinghuang commented on a change in pull request #575: realize rowset remove
api
URL: https://github.com/apache/incubator-doris/pull/575#discussion_r251317979
##########
File path: be/src/olap/rowset/alpha_rowset.cpp
##########
@@ -60,9 +68,16 @@ OLAPStatus AlphaRowset::copy(RowsetWriter*
dest_rowset_writer) {
}
OLAPStatus AlphaRowset::remove() {
- // TODO(hkp) : add delete code
- // delete rowset from meta
- // delete segment groups
+ OlapMeta* meta = _data_dir->get_meta();
+ OLAPStatus status = RowsetMetaManager::remove(meta, rowset_id());
Review comment:
file gc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]