kangpinghuang commented on a change in pull request #596: Add implementation to
tablet
URL: https://github.com/apache/incubator-doris/pull/596#discussion_r252101314
##########
File path: be/src/olap/rowset/alpha_rowset_writer.cpp
##########
@@ -160,9 +161,9 @@ RowsetSharedPtr AlphaRowsetWriter::build() {
alpha_rowset_meta->add_segment_group(segment_group_pb);
}
}
- Rowset* rowset = new AlphaRowset(_rowset_writer_context.tablet_schema,
- _rowset_writer_context.rowset_path_prefix,
- _rowset_writer_context.data_dir,
_current_rowset_meta);
+ RowsetSharedPtr rowset(new
AlphaRowset(_rowset_writer_context.tablet_schema,
+ _rowset_writer_context.rowset_path_prefix,
+ _rowset_writer_context.data_dir,
_current_rowset_meta));
rowset->init();
return std::shared_ptr<Rowset>(rowset);
Review comment:
return rowset directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
