chaoyli commented on a change in pull request #628: Fix bug in rollback txn case
URL: https://github.com/apache/incubator-doris/pull/628#discussion_r256386453
##########
File path: be/src/olap/delta_writer.cpp
##########
@@ -46,12 +46,20 @@ DeltaWriter::~DeltaWriter() {
}
void DeltaWriter::_garbage_collection() {
- TxnManager::instance()->rollback_txn(_req.partition_id,
_req.txn_id,_req.tablet_id, _req.schema_hash);
- StorageEngine::instance()->add_unused_rowset(_cur_rowset);
+ OLAPStatus rollback_status =
TxnManager::instance()->rollback_txn(_req.partition_id,
Review comment:
In this place, if data has generated but rowset is not been created, how to
GC data?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
