[GitHub] chaoyli commented on a change in pull request #635: Fix reader bug

Fri, 15 Feb 2019 00:11:46 -0800 

chaoyli commented on a change in pull request #635: Fix reader bug
URL: https://github.com/apache/incubator-doris/pull/635#discussion_r257136741
 
 

 ##########
 File path: be/src/olap/rowset/alpha_rowset_reader.cpp
 ##########
 @@ -150,10 +149,7 @@ OLAPStatus 
AlphaRowsetReader::_get_next_not_filtered_row(size_t pos, RowCursor**
             }
         }
         if (!current_row_block->has_remaining()) {
-            OLAPStatus status = _get_next_block(pos, &current_row_block);
-            if (status != OLAP_SUCCESS) {
-                return status;
-            }
+            _get_next_block(pos, &current_row_block);
 
 Review comment:
   You should return OLAPStatus when error happens

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to