chaoyli commented on a change in pull request #643: Import TabletState and
remove mutex in TabletMeta
URL: https://github.com/apache/incubator-doris/pull/643#discussion_r258321154
##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -555,8 +552,8 @@ TabletSharedPtr TabletManager::get_tablet(TTabletId
tablet_id, SchemaHash schema
if (!tablet->is_used()) {
OLAP_LOG_WARNING("tablet cannot be used. [tablet=%ld]", tablet_id);
tablet.reset();
- } else if (load_tablet && !tablet->is_loaded()) {
- if (tablet->load() != OLAP_SUCCESS) {
+ } else if (load_tablet && !tablet->init_success()) {
Review comment:
I think init_succeeded may be better to describe it.
is_inited can not differentiate success or fail literally
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
