kangpinghuang commented on a change in pull request #656: Modify alter tablet 
implementation and change ColumnPruning to ZoneMap
URL: https://github.com/apache/incubator-doris/pull/656#discussion_r259685095
 
 

 ##########
 File path: be/src/olap/cumulative_compaction.cpp
 ##########
 @@ -452,9 +453,6 @@ OLAPStatus 
CumulativeCompaction::_do_cumulative_compaction() {
     // 6. delete delta files which have been merged into new cumulative file
     _delete_unused_delta_files(&unused_rowsets);
 
 Review comment:
   rename this function name to _delete_unused_rowset?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to