kangpinghuang commented on a change in pull request #656: Modify alter tablet
implementation and change ColumnPruning to ZoneMap
URL: https://github.com/apache/incubator-doris/pull/656#discussion_r259688336
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1279,56 +1244,48 @@ OLAPStatus SchemaChangeHandler::_do_alter_tablet(
for (int64_t transaction_id : transaction_ids) {
if (!TxnManager::instance()->has_txn(
partition_id, transaction_id,
- ref_tablet->tablet_id(), ref_tablet->schema_hash())) {
+ base_tablet->tablet_id(), base_tablet->schema_hash())) {
finished_transactions.push_back(transaction_id);
}
}
for (int64_t transaction_id : finished_transactions) {
transaction_ids.erase(transaction_id);
VLOG(3) << "transaction finished when schema change is waiting. "
- << "tablet=" << ref_tablet->full_name()
+ << "tablet=" << base_tablet->full_name()
<< ", transaction_id=" << transaction_id
<< ", transaction_size=" << transaction_ids.size();
}
}
// 2. Get version_to_be_changed and store into tablet header
- ref_tablet->obtain_push_lock();
- ref_tablet->obtain_header_wrlock();
+ base_tablet->obtain_push_lock();
+ base_tablet->obtain_header_wrlock();
Review comment:
this name should be rename to obtain_meta_wrlock?
header should not be used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
