chaoyli commented on a change in pull request #656: Modify alter tablet
implementation and change ColumnPruning to ZoneMap
URL: https://github.com/apache/incubator-doris/pull/656#discussion_r259710974
##########
File path: be/src/olap/olap_cond.cpp
##########
@@ -601,25 +601,24 @@ bool Conditions::delete_conditions_eval(const RowCursor&
row) const {
}
bool Conditions::delta_pruning_filter(
- const std::vector<std::pair<WrapperField*, WrapperField*>>&
column_statistics) const {
+ const std::vector<std::pair<WrapperField*, WrapperField*>>& zone_maps)
const {
//通过所有列上的删除条件对version进行过滤
for (auto& cond_it : _columns) {
- if (cond_it.second->is_key() && cond_it.first >
column_statistics.size()) {
- OLAP_LOG_WARNING("where condition not equal column statistics
size."
- "[cond_id=%d, column_statistics_size=%lu]",
- cond_it.first,
- column_statistics.size());
+ if (cond_it.second->is_key() && cond_it.first > zone_maps.size()) {
+ LOG(WARNING) << "where condition not equal zone maps size. "
+ << "cond_id=" << cond_it.first
+ << ", zone_map_size=" << zone_maps.size();
return false;
}
- if (cond_it.second->is_key() &&
!cond_it.second->eval(column_statistics[cond_it.first])) {
+ if (cond_it.second->is_key() &&
!cond_it.second->eval(zone_maps[cond_it.first])) {
return true;
}
}
return false;
}
int Conditions::delete_pruning_filter(
- const std::vector<std::pair<WrapperField*, WrapperField*>>& col_stat)
const {
+ const std::vector<std::pair<WrapperField*, WrapperField*>>& zone_maps)
const {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
