morningman commented on a change in pull request #665: Change routine load task
sheduler interval to 0
URL: https://github.com/apache/incubator-doris/pull/665#discussion_r260563835
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java
##########
@@ -57,13 +59,20 @@
private String serverAddress;
private String topic;
// optional, user want to load partitions.
- private List<Integer> kafkaPartitions;
+ private List<Integer> customKafkaPartitions;
+ // current kafka partitions is the actually partition which will be fetched
+ private List<Integer> currentKafkaPartitions;
+
+ private KafkaConsumer<String, String> consumer;
Review comment:
Better to comment the meaning of <String, String>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
