morningman commented on a change in pull request #684: Modify interface
URL: https://github.com/apache/incubator-doris/pull/684#discussion_r262024889
##########
File path: be/src/service/backend_service.cpp
##########
@@ -230,9 +230,19 @@ void BackendService::get_tablet_stat(TTabletStatResult&
result) {
}
void BackendService::submit_routine_load_task(
- TStatus& t_status, const TRoutineLoadTask& task) {
- Status status = _exec_env->routine_load_task_executor()->submit_task(task);
- status.to_thrift(&t_status);
+ TStatus& t_status, const std::vector<TRoutineLoadTask>& tasks) {
+
+ for (auto& task : tasks) {
Review comment:
First, it is very unlikely to submit failed. And just make is simple here.
Let FE handle the error now.(may be timeout).
It will be changed later if this is a big deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
