morningman commented on a change in pull request #687: Put begin txn into task
scheduler
URL: https://github.com/apache/incubator-doris/pull/687#discussion_r262384780
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskInfo.java
##########
@@ -79,8 +73,16 @@ public long getLoadStartTimeMs() {
public long getTxnId() {
return txnId;
}
-
- abstract TRoutineLoadTask createRoutineLoadTask(long beId) throws
LoadException, UserException;
+
+ abstract TRoutineLoadTask createRoutineLoadTask() throws LoadException,
UserException;
+
+ public void setTxn() throws LabelAlreadyUsedException,
BeginTransactionException, AnalysisException {
Review comment:
better to name it 'beginTxn'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
