morningman commented on a change in pull request #703: Change the relationship
between txn and task
URL: https://github.com/apache/incubator-doris/pull/703#discussion_r263333553
##########
File path:
fe/src/main/java/org/apache/doris/analysis/CreateRoutineLoadStmt.java
##########
@@ -326,6 +335,16 @@ private void checkKafkaCustomProperties() throws
AnalysisException {
}
}
}
+ // check offsets
+ // Todo(ml)
+ final String kafkaOffsetsString =
customProperties.get(KAFKA_OFFSETS_PROPERTY);
+ if (kafkaOffsetsString != null) {
+ kafkaOffsets = new ArrayList<>();
+ String[] kafkaOffsetsStringList =
customProperties.get(KAFKA_OFFSETS_PROPERTY).split(",");
+ for (String s : kafkaOffsetsStringList) {
+ kafkaOffsets.add(Long.valueOf(s));
Review comment:
You should check the number format. And also check whether the number of
specified offsets equals to number of specified partitions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
