chaoyli commented on a change in pull request #688: Add path GC for BE
URL: https://github.com/apache/incubator-doris/pull/688#discussion_r263348401
##########
File path: be/src/olap/cumulative_compaction.cpp
##########
@@ -378,14 +382,14 @@ OLAPStatus
CumulativeCompaction::_do_cumulative_compaction() {
uint64_t filted_rows = 0;
res = merger.merge(_rs_readers, &merged_rows, &filted_rows);
if (res != OLAP_SUCCESS) {
- OLAP_LOG_WARNING("failed to do cumulative merge. [tablet=%s;
cumulative_version=%d-%d]",
- _tablet->full_name().c_str(),
- _cumulative_version.first,
- _cumulative_version.second);
+ LOG(WARNING) << "failed to do cumulative merge. "
+ << "tablet=" << _tablet->full_name()
+ << ", cumulative_version=" << _cumulative_version.first
<< "-" << _cumulative_version.second;
return res;
}
_rowset = _rs_writer->build();
+ StorageEngine::instance()->remove_pending_paths(_rs_writer->rowset_id());
Review comment:
forget to remove when base compaction failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
