kangpinghuang commented on a change in pull request #712: Rename rowset id
after clone from remote
URL: https://github.com/apache/incubator-doris/pull/712#discussion_r263734391
##########
File path: be/src/olap/rowset/rowset.h
##########
@@ -34,20 +34,23 @@ class RowsetReader;
class Rowset : public std::enable_shared_from_this<Rowset> {
public:
+ Rowset() : _is_inited(false), _is_loaded(false) {
+ }
+
virtual ~Rowset() { }
// this api is for init related objects in memory
virtual OLAPStatus init() = 0;
- bool is_inited() {
+ virtual bool is_inited() {
Review comment:
virtual is no need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
