morningman commented on a change in pull request #697: Optimize decimal by
introducing decimal_v2 (#695)
URL: https://github.com/apache/incubator-doris/pull/697#discussion_r263660079
##########
File path: fe/src/main/java/org/apache/doris/catalog/Column.java
##########
@@ -255,7 +255,11 @@ public void checkSchemaChangeAllowed(Column other) throws
DdlException {
public String toSql() {
StringBuilder sb = new StringBuilder();
sb.append("`").append(name).append("` ");
- sb.append(type.toSql()).append(" ");
+ String typeStr = type.toSql();
+ if (type.getPrimitiveType() == PrimitiveType.DECIMALV2) {
Review comment:
Why not implement this if{} in type.toSql()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
