linoclapton commented on a change in pull request #762: modify the replay logic
of routine load job
URL: https://github.com/apache/incubator-doris/pull/762#discussion_r266196999
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -147,10 +144,14 @@ public boolean isFinalState() {
protected String cancelReason;
protected long endTimestamp;
- // currentErrorNum and currentTotalNum will be update
- // when currentTotalNum is more then ten thousand or currentErrorNum is
more then maxErrorNum
- protected long currentErrorNum;
- protected long currentTotalNum;
+ /*
+ * currentErrorRows and currentTotalRows is used for check error rate
+ * errorRows and totalRows are used for statistics
+ */
+ protected long currentErrorRows;
Review comment:
please use int for currentErrorNum and currentTotalNum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
