kangpinghuang commented on a change in pull request #772: Be refactor new fix
test bug
URL: https://github.com/apache/incubator-doris/pull/772#discussion_r266748797
##########
File path: be/src/olap/reader.cpp
##########
@@ -467,7 +467,7 @@ OLAPStatus Reader::_capture_rs_readers(const ReaderParams&
read_params) {
rs_readers = &read_params.rs_readers;
} else {
_tablet->obtain_header_rdlock();
- _tablet->capture_rs_readers(_version, &_own_rs_readers);
+ RETURN_NOT_OK(_tablet->capture_rs_readers(_version, &_own_rs_readers));
_tablet->release_header_lock();
Review comment:
Here return not ok means that the reader init failed and the reading will
return failed directly. I think it is a right process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
