kangpinghuang commented on a change in pull request #895: Remove old files
after tablet is successfully loaded
URL: https://github.com/apache/incubator-doris/pull/895#discussion_r273770294
##########
File path: be/src/olap/data_dir.h
##########
@@ -123,7 +123,7 @@ class DataDir {
Status _write_cluster_id_to_path(const std::string& path, int32_t
cluster_id);
OLAPStatus _clean_unfinished_converting_data();
OLAPStatus _convert_old_tablet();
- OLAPStatus _remove_old_meta_and_files();
+ OLAPStatus _remove_old_meta_and_files(std::set<int64_t>& tablet_ids);
Review comment:
```suggestion
OLAPStatus _remove_old_meta_and_files(const std::set<int64_t>&
tablet_ids);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]