kangpinghuang commented on a change in pull request #932: Refactor tablet mgr
code
URL: https://github.com/apache/incubator-doris/pull/932#discussion_r275694616
##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -81,13 +81,12 @@ TabletManager::TabletManager()
: _tablet_stat_cache_update_time_ms(0),
_available_storage_medium_type_count(0) { }
-OLAPStatus TabletManager::add_tablet(TTabletId tablet_id, SchemaHash
schema_hash,
+OLAPStatus TabletManager::_add_tablet_unlock(TTabletId tablet_id, SchemaHash
schema_hash,
const TabletSharedPtr& tablet, bool force) {
OLAPStatus res = OLAP_SUCCESS;
VLOG(3) << "begin to add tablet to TabletManager. "
<< "tablet_id=" << tablet_id << ", schema_hash=" << schema_hash
<< ", force=" << force;
- _tablet_map_lock.wrlock();
TabletSharedPtr table_item;
Review comment:
```suggestion
TabletSharedPtr tablet_item = nullptr;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
