EmmyMiao87 commented on a change in pull request #938: Add error load log url
for routine load job
URL: https://github.com/apache/incubator-doris/pull/938#discussion_r275781338
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -925,31 +946,37 @@ public void setOrigStmt(String origStmt) {
}
}
- List<String> row = Lists.newArrayList();
- row.add(String.valueOf(id));
- row.add(name);
- row.add(TimeUtils.longToTimeString(createTimestamp));
- row.add(TimeUtils.longToTimeString(endTimestamp));
- row.add(db == null ? String.valueOf(dbId) : db.getFullName());
- row.add(tbl == null ? String.valueOf(tableId) : tbl.getName());
- row.add(getState().name());
- row.add(dataSourceType.name());
- row.add(String.valueOf(getSizeOfRoutineLoadTaskInfoList()));
- row.add(jobPropertiesToJsonString());
- row.add(dataSourcePropertiesJsonToString());
- row.add(getStatistic());
- row.add(getProgress().toJsonString());
- switch (state) {
- case PAUSED:
- row.add(pausedReason);
- break;
- case CANCELLED:
- row.add(cancelReason);
- break;
- default:
- row.add("");
+ readLock();
Review comment:
The strong consistency need be protected in here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
