chaoyli commented on a change in pull request #932: Refactor tablet mgr code
URL: https://github.com/apache/incubator-doris/pull/932#discussion_r276061037
##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -263,11 +301,11 @@ OLAPStatus TabletManager::create_tablet(const
TCreateTabletReq& request,
return res;
} // create_tablet
-
TabletSharedPtr TabletManager::create_tablet(
const TCreateTabletReq& request, const bool is_schema_change_tablet,
const TabletSharedPtr ref_tablet, std::vector<DataDir*> data_dirs) {
- WriteLock wrlock(&_create_tablet_lock);
+ DCHECK(is_schema_change_tablet && ref_tablet != nullptr);
Review comment:
DCHECK((is_schema_change_tablet && ref_tablet != nullptr) ||
(!is_schema_change_tablet && ref_tablet == nullptr));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
