kangpinghuang commented on a change in pull request #950: set shard id when 
load from dir
URL: https://github.com/apache/incubator-doris/pull/950#discussion_r276504991
 
 

 ##########
 File path: be/src/olap/tablet_manager.cpp
 ##########
 @@ -151,17 +151,11 @@ OLAPStatus TabletManager::_add_tablet_unlock(TTabletId 
tablet_id, SchemaHash sch
 } // add_tablet
 
 OLAPStatus TabletManager::_add_tablet_to_map(TTabletId tablet_id, SchemaHash 
schema_hash,
-                                 const TabletSharedPtr& tablet, bool 
keep_files, bool drop_old) {
+                                 const TabletSharedPtr& tablet, bool 
update_meta, 
+                                 bool keep_files, bool drop_old) {
 
 Review comment:
   add a comment to explain the drop_old and update_meta

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to