chenhao7253886 commented on a change in pull request #1003: Support kafka
routine load
URL: https://github.com/apache/incubator-doris/pull/1003#discussion_r277932354
##########
File path: fe/src/main/java/org/apache/doris/common/util/Daemon.java
##########
@@ -106,8 +106,8 @@ public void run() {
while (!isStop.get()) {
try {
runOneCycle();
- } catch (Exception e) {
- LOG.error("exception: ", e);
+ } catch (Throwable e) {
Review comment:
Why catch throwable. because derived class such as Error should't be
catched. we are only catch exceptions except RuntimeException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
