morningman commented on a change in pull request #1003: Support kafka routine
load
URL: https://github.com/apache/incubator-doris/pull/1003#discussion_r277966839
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -1385,24 +1394,27 @@ public long loadMasterInfo(DataInputStream dis, long
checksum) throws IOExceptio
}
public long loadFrontends(DataInputStream dis, long checksum) throws
IOException {
- int size = dis.readInt();
- long newChecksum = checksum ^ size;
- for (int i = 0; i < size; i++) {
- Frontend fe = Frontend.read(dis);
- replayAddFrontend(fe);
- }
-
- size = dis.readInt();
- newChecksum ^= size;
- for (int i = 0; i < size; i++) {
- if (Catalog.getCurrentCatalogJournalVersion() <
FeMetaVersion.VERSION_41) {
+ if (Catalog.getCurrentCatalogJournalVersion() >=
FeMetaVersion.VERSION_22) {
Review comment:
I just move this judgement inside the loadFrontends() method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
