chenhao7253886 commented on a change in pull request #925: Doris on ES by HTTP
way
URL: https://github.com/apache/incubator-doris/pull/925#discussion_r277973798
##########
File path: fe/src/main/java/org/apache/doris/catalog/EsTable.java
##########
@@ -106,8 +114,16 @@ private void validate(Map<String, String> properties)
throws DdlException {
&& !Strings.isNullOrEmpty(properties.get(TYPE).trim())) {
mappingType = properties.get(TYPE).trim();
}
+ if (!Strings.isNullOrEmpty(properties.get(TRANSPORT))
+ && !Strings.isNullOrEmpty(properties.get(TRANSPORT).trim())) {
+ transport = properties.get(TRANSPORT).trim();
+ if (!(TRANSPORT_HTTP.equals(transport) ||
TRANSPORT_THRIFT.equals(transport))) {
Review comment:
Properties get same key three times, it better add tmp variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
