imay commented on a change in pull request #1146: Set tablet as bad when
loading index failed
URL: https://github.com/apache/incubator-doris/pull/1146#discussion_r283126458
##########
File path: be/src/olap/olap_engine.cpp
##########
@@ -835,6 +840,10 @@ OLAPStatus OLAPEngine::get_tables_by_id(
it = table_list->erase(it);
continue;
}
+ } else if ((*it)->is_used()) {
Review comment:
why not check if `(*it)->is_bad()`
I'm afraid when tablet is not bad and it is not used, you erase it. which is
not what we want
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
