worker24h commented on a change in pull request #1173: load data from Parquet
file (Issues #911)
URL: https://github.com/apache/incubator-doris/pull/1173#discussion_r285411759
##########
File path: be/src/exec/broker_scanner.h
##########
@@ -48,40 +49,26 @@ class MemTracker;
class RuntimeProfile;
class StreamLoadPipe;
-struct BrokerScanCounter {
- BrokerScanCounter() :
- num_rows_total(0),
- // num_rows_returned(0),
- num_rows_filtered(0),
- num_rows_unselected(0) {
- }
-
- int64_t num_rows_total; // total read rows (read from source)
- // int64_t num_rows_returned; // qualified rows (match the dest schema)
- int64_t num_rows_filtered; // unqualified rows (unmatch the dest schema,
or no partition)
- int64_t num_rows_unselected; // rows filterd by predicates
-};
-
// Broker scanner convert the data read from broker to doris's tuple.
-class BrokerScanner {
+class BrokerScanner : public ScannerInterface {
public:
BrokerScanner(
RuntimeState* state,
RuntimeProfile* profile,
const TBrokerScanRangeParams& params,
const std::vector<TBrokerRangeDesc>& ranges,
const std::vector<TNetworkAddress>& broker_addresses,
- BrokerScanCounter* counter);
+ ScannerCounter* counter);
~BrokerScanner();
- // Open this scanner, will initialize informtion need to
- Status open();
+ // Open this scanner, will initialize information need to
+ virtual Status open();
- // Get next tuple
- Status get_next(Tuple* tuple, MemPool* tuple_pool, bool* eof);
+ // Get next tuple
+ virtual Status get_next(Tuple* tuple, MemPool* tuple_pool, bool* eof);
Review comment:
ok i had changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
