imay commented on a change in pull request #1173: load data from Parquet file
(Issues #911)
URL: https://github.com/apache/incubator-doris/pull/1173#discussion_r285458279
##########
File path: be/src/exec/local_file_reader.cpp
##########
@@ -36,53 +36,71 @@ Status LocalFileReader::open() {
<< ", error=" << strerror_r(errno, err_buf, 64);
return Status(ss.str());
}
+ // get file size
Review comment:
you'd better not get size in open function
you can get through `size` function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
