kangpinghuang commented on a change in pull request #1211: Change 
FileDownloader to http client
URL: https://github.com/apache/incubator-doris/pull/1211#discussion_r288369590
 
 

 ##########
 File path: be/src/olap/task/engine_batch_load_task.cpp
 ##########
 @@ -113,45 +113,31 @@ AgentStatus EngineBatchLoadTask::_init() {
         LOG(WARNING) << "get tables failed. "
                      << "tablet_id: " << _push_req.tablet_id
                      << ", schema_hash: " << _push_req.schema_hash;
-        status = DORIS_PUSH_INVALID_TABLE;
+        return DORIS_PUSH_INVALID_TABLE;
     }
 
     // Empty remote_path
-    if (status == DORIS_SUCCESS && !_push_req.__isset.http_file_path) {
+    if (!_push_req.__isset.http_file_path) {
         _is_init = true;
         return status;
     }
-
+    
 
 Review comment:
   extra empty

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to