EmmyMiao87 commented on a change in pull request #1240: Fix
IllegalArgumentException in LoadManager
URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290268959
##########
File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java
##########
@@ -294,6 +294,10 @@ public void submitJobs() {
loadJob -> loadJob.state ==
JobState.PENDING).collect(Collectors.toList()));
}
+ Map<Long, LoadJob> getIdToLoadJobs() {
Review comment:
> > You can use the invoke function to access these method.
>
> I don't think use reflection is necessary in here.
The function of Deencapsulation.invoke() specifically designed to test
private method without change private to default.
So maybe Deencapsulation.invoke() is better? It can keep the smaller
accessible level for `getIdToLoadJobs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
