imay commented on a change in pull request #1235: Support SSL authentication
with Kafka in routine load job
URL: https://github.com/apache/incubator-doris/pull/1235#discussion_r290335722
##########
File path: be/src/runtime/routine_load/data_consumer.cpp
##########
@@ -199,6 +227,66 @@ Status KafkaDataConsumer::group_consume(
return st;
}
+Status KafkaDataConsumer::get_partition_meta(std::vector<int32_t>*
partition_ids) {
+ // create topic conf
+ RdKafka::Conf *tconf = RdKafka::Conf::create(RdKafka::Conf::CONF_TOPIC);
+ auto conf_deleter = [tconf] () { delete tconf; };
+ DeferOp delete_conf(std::bind<void>(conf_deleter));
+
+ // create topic
+ std::string errstr;
+ RdKafka::Topic *topic = RdKafka::Topic::create(_k_consumer, _topic, tconf,
errstr);
+ if (!topic) {
Review comment:
```suggestion
if (topic != nullptr) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]