EmmyMiao87 commented on a change in pull request #1235: Support SSL
authentication with Kafka in routine load job
URL: https://github.com/apache/incubator-doris/pull/1235#discussion_r291004804
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java
##########
@@ -62,19 +63,17 @@
public class KafkaRoutineLoadJob extends RoutineLoadJob {
private static final Logger LOG =
LogManager.getLogger(KafkaRoutineLoadJob.class);
- private static final int FETCH_PARTITIONS_TIMEOUT_SECOND = 5;
+ public static final String KAFKA_FILE_CATALOG = "kafka";
private String brokerList;
private String topic;
// optional, user want to load partitions.
private List<Integer> customKafkaPartitions = Lists.newArrayList();
// current kafka partitions is the actually partition which will be fetched
private List<Integer> currentKafkaPartitions = Lists.newArrayList();
- //kafka properties ，property prefix will be mapped to kafka custom
parameters, which can be extended in the future
+ // kafka properties ，property prefix will be mapped to kafka custom
parameters, which can be extended in the future
private Map<String, String> customKafkaProperties = Maps.newHashMap();
-
- // this is the kafka consumer which is used to fetch the number of
partitions
- private KafkaConsumer<String, String> consumer;
+ private Map<String, String> convertedCustomProperties = Maps.newHashMap();
Review comment:
why don't you merge `convertedCustomProperties ` into `customKafkaProperties
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
